search

dwavesystems / minorminer

minorminer is a heuristic tool for minor embedding: given a minor and target graph, it tries to find a mapping that embeds the minor into the target.
https://docs.ocean.dwavesys.com/en/stable/docs_minorminer/source/sdk_index.html
Apache License 2.0
48 stars 40 forks source link

Fix build for AppVeyor #158

Closed hhtong closed 4 years ago

boothby commented 4 years ago

Is this only on Py3.5? That's in EOL, can we drop it now?

arcondello commented 4 years ago

@boothby, good point. Should we just be dropping 3.5 in Ocean generally? @randomir

https://github.com/dwavesystems/dwave-ocean-sdk/issues/91

randomir commented 4 years ago

No, @boothby, it's on all versions.

@arcondello, sure, I don't mind dropping 3.5.

randomir commented 4 years ago

@hhtong, as long as you're fixing appveyor, can you also add tests for py38?

hhtong commented 4 years ago

@randomir Will do that right now. Should I also be removing the tests for 3.5 then? Or wait

arcondello commented 4 years ago

I would wait on 3.5, it's a bigger conversation.

randomir commented 4 years ago

@hhtong, I would wait with py35. It's not solving anything, and it's not in our way right now.