search

dwbutler / logstash-logger

Ruby logger that writes logstash events
MIT License
456 stars 119 forks source link

Allow type to be a string for multi_logger and syslog #131

Closed AlexeyKrasnoperov closed 7 years ago

AlexeyKrasnoperov commented 7 years ago

Now there is an inconsistency in creating loggers:

You can create logger with type: 'file', but you will get an error if you would try to create a logger with type: 'syslog' or type: 'multi_logger'. Syslog and Multi_logger only accept symbol as a type.

I made logger creation the same for 'default logger' and for syslog and multi_logger.

codecov-io commented 7 years ago

Codecov Report

Merging #131 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   92.81%   92.83%   +0.02%     
==========================================
  Files          64       64              
  Lines        1628     1633       +5     
==========================================
+ Hits         1511     1516       +5     
  Misses        117      117
Impacted Files Coverage Δ
spec/syslog_spec.rb 100% <100%> (ø) :arrow_up:
lib/logstash-logger/logger.rb 84.48% <100%> (+0.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a40fbb5...fdf7953. Read the comment docs.

AlexeyKrasnoperov commented 7 years ago

@dwbutler