dwbutler / logstash-logger

Ruby logger that writes logstash events
MIT License
454 stars 118 forks source link

Gracefully handle json Encoding::UndefinedConversionError #165

Open marcoadkins opened 3 years ago

marcoadkins commented 3 years ago

This addresses: #159 and #158

Things Done:

codecov-commenter commented 3 years ago

Codecov Report

Merging #165 into master will increase coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   92.68%   92.79%   +0.10%     
==========================================
  Files          64       64              
  Lines        1668     1735      +67     
==========================================
+ Hits         1546     1610      +64     
- Misses        122      125       +3     
Impacted Files Coverage Δ
lib/logstash-logger/formatter.rb 96.87% <100.00%> (ø)
lib/logstash-logger/formatter/base.rb 100.00% <100.00%> (ø)
lib/logstash-logger/formatter/json.rb 100.00% <100.00%> (ø)
lib/logstash-logger/formatter/json_lines.rb 100.00% <100.00%> (ø)
lib/logstash-logger/logger.rb 83.60% <100.00%> (ø)
spec/formatter/base_spec.rb 100.00% <100.00%> (ø)
spec/formatter/json_lines_spec.rb 100.00% <100.00%> (ø)
spec/formatter/json_spec.rb 100.00% <100.00%> (ø)
lib/logstash-logger/device/kinesis.rb 88.88% <0.00%> (-5.56%) :arrow_down:
lib/logstash-logger/device/firehose.rb 88.88% <0.00%> (-5.56%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8f5403...56068e9. Read the comment docs.