search

dwcaress / MB-System

MB-System is an open source software package for the processing and display of bathymetry and backscatter imagery data derived from multibeam, interferometry, and sidescan sonars.
https://www.mbari.org/products/research-software/mb-system/
Other
127 stars 45 forks source link

sync with build changes in libtrnav #1492

Closed klheadley closed 2 weeks ago

klheadley commented 2 weeks ago

sync with build file changes in libtrnav. This primarily involves gnu make and sentry cmake/gnu make build scripts to fix issues (e.g. opt/rov linkage errors under linux) and integrate opt/rov (trnxpp) target at the top level.

Suppress gctp warnings (geolib build target only); the warnings are for future deprecation in the open C2X standard. Until it is deprecated (becomes and error), it makes sense to disable the warning for that target, rather than do extensive modification to gctp source.

Also fixes (not suppresses) warnings in mbtrnav/qnx-utils (DataLogReader,TimeP) and mbtrnutils (mbtrnpp).

Excludes files used by MB-System build. Tested on macOS Sonoma 14.7 and Ubuntu 22.04 LTS.

klheadley commented 2 weeks ago

Though I didn't change it here, removing the -m dependency from all targets in src/utilities/CMakeLists.txt eliminated a number of duplicate library warnings on macOS Sonoma/cmake 3.29.2 (and possibly Ubuntu 22.04/cmake 3.29.6). These warnings seem new and may be related to the latest Xcode tools (on macOS).

I'm seeing quite a few warnings under linux; these are mostly potential buffer/memory overruns and/or truncations, unchecked return values.

All of that's out of scope for this change set, but maybe worth looking into in a future release.

klheadley commented 2 weeks ago

Thanks Dave!

On Nov 14, 2024, at 08:54, David Caress @.***> wrote:

[POSSIBLE IMPERSONATION: This message is using the name of an MBARI account holder and has originated from outside of the organization. Please review the content and sender information carefully.]

Merged #1492 https://github.com/dwcaress/MB-System/pull/1492 into master.

— Reply to this email directly, view it on GitHub https://github.com/dwcaress/MB-System/pull/1492#event-15301684846, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZRTZPF32DKJ5D45RSVKWD2ATIVVAVCNFSM6AAAAABRQ5EJX2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGMYDCNRYGQ4DINQ. You are receiving this because you authored the thread.