--enable-mbtrn broken - Githubissues

schwehr commented 5 years ago

Sorry for the breakage. I didn't realize that mbtrn is embedded in mb_io.h and used in src/utilities/mbtrnpreprocess.c. I thought src/mbtrn was totally standalone. I'm working on getting it back into shape.

Along with that, there is something wrong with MBF_ELMK2UNB

schwehr commented 5 years ago

// test/utilities/testdata/mb92/TN136HS.309.snipped.mb92.json2
{
  "file_info": {
    "swath_data_file": "TN136HS.309.snipped.mb92",
    "mbio_data_format_id": "92",
    "format_name": "MBF_ELMK2UNB",
    "informal_description": "Elac BottomChart MkII shallow water multibeam",
    "attributes": "126 beam bathymetry and amplitude,;                      binary, University of New Brunswick."
  },
  "data_totals": {
    "number_of_records": "2"
  },
  "bathymetry_data": {
    "max_beams_per_ping": "0",
    "number_beams": "0",
    "number_good_beams": "0",
    "percent_good_beams": " 0.00",
    "number_zero_beams": "0",
    "percent_zero_beams": " 0.00",
    "number_flagged_beams": "0",
    "percent_flagged_beams": " 0.00"
  },
  "amplitude_data": {
    "max_beams_per_ping": "0",
    "number_beams": "0",
    "number_good_beams": "0",
    "percent_good_beams": "  0.00",
    "number_zero_beams": "0",
    "percent_zero_beams": " 0.00",
    "number_flagged_beams": "0",
    "percent_flagged_beams": " 0.00"
  },
  "sidescan_data": {
    "max_pixels_per_ping": "0",
    "number_of_pixels": "0",
    "number_good_pixels": "0",
    "percent_good_pixels": " 0.00",
    "number_zero_pixels": "0",
    "percent_zero_pixels": " 0.00",
    "number_flagged_pixels": "0",
    "percent_flagged_pixels": " 0.00"
  },
  "navigation_totals": {
    "total_time_hours": "0.0014",
    "total_track_length_km": "73.1796",
    "average_speed_km_per_hr": "52689.2824",
    "average_speed_knots": "28480.6932"
  },
  "start_of_data": {
    "time": "11 05 2001 00:01:44.000000  JD309",
    "time_iso": "2001-11-05T00:01:44.000000",
    "longitude": "0.000000000",
    "latitude": "0.000000000",
    "depth_meters": "0.0000",
    "speed_km_per_hour": "0.0000",
    "speed_knots": "0.0000",
    "heading_degrees": "324.5000",
    "sonar_depth_meters": "0.0000",
    "sonar_altitude_meters": "0.0000"
  },
  "end_of_data": {
    "time": "11 05 2001 00:01:49.000000  JD309",
    "time_iso": "2001-11-05T00:01:49.000000",
    "longitude": "0.000000000",
    "latitude": "0.661812699",
    "depth_meters": "0.0000",
    "speed_km_per_hour": "52689.2403",
    "speed_knots": "28480.6704",
    "heading_degrees": "324.8900",
    "sonar_depth_meters": "0.0000",
    "sonar_altitude_meters": "0.0000"
  },
  "limits": {
    "minimum_longitude": "0.000000000",
    "maximum_longitude": "0.000000000",
    "minimum_latitude": "0.000000000",
    "maximum_latitude": "0.661812699",
    "minimum_sonar_depth": "0.0000",
    "maximum_sonar_depth": "0.0000",
    "minimum_altitude": "0.0000",
    "maximum_altitude": "0.0000"
  }}

schwehr commented 4 years ago

Currently, --enable-mbtrn cannot build without --enable-mbtnav. It would be good to have more test configs!

dwcaress commented 4 years ago

Kurt,

Yes, this is a problem Kent and I need to address. The code is intended to allow building mbtrnpp with and without an embedded TRN engine. If we need to keep this model, then the trnw directory needs to move from mbtnav to mbtrn. I’m not sure how long the latter case will be relevant or needed.

Another problem right now is the need to include r7k-reader.h in mbr_reson7k3.c and mbr_reson7k. We need to abstract the socket reading function so that the code is looking for a generic ftell-like function rather than looking specifically for r7kr_reader_tell(().

Dave

On Jan 5, 2020, at 10:15 AM, Kurt Schwehr notifications@github.com wrote:

Currently, --enable-mbtrn cannot build without --enable-mbtnav. It would be good to have more test configs!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

David W. Caress Principal Engineer Seafloor Mapping Lab

Monterey Bay Aquarium Research Institute 7700 Sandholdt Road Moss Landing, CA 95039

caress@mbari.org http://www.mbari.org/~caress/

Phone: 831-775-1775

dwcaress commented 4 years ago

Dave,

Let’s talk to Steve. Other refactoring has since taken place, and it’s possible to switch the TRN engine in/out using a command line option. My sense is that it’s stable enough to remove the --enable-mbtnav scaffolding, but it would good to see if Steve is on board.

Let’s talk about the ftell function when I’m back, and I’ll take a look at the code in the meantime. And we have a couple of loose ends to resolve with respect to the trndev branch; I’ve got a pending commit that I’d like to before things change too much. Mostly, I’d like to get the wiggles out of our work flow (and/or my git craft :o).

Kent

On Jan 5, 2020, at 11:37 PM, caress caress@mbari.org wrote:

Kurt,

Yes, this is a problem Kent and I need to address. The code is intended to allow building mbtrnpp with and without an embedded TRN engine. If we need to keep this model, then the trnw directory needs to move from mbtnav to mbtrn. I’m not sure how long the latter case will be relevant or needed.

Another problem right now is the need to include r7k-reader.h in mbr_reson7k3.c and mbr_reson7k. We need to abstract the socket reading function so that the code is looking for a generic ftell-like function rather than looking specifically for r7kr_reader_tell(().

Dave

On Jan 5, 2020, at 10:15 AM, Kurt Schwehr notifications@github.com wrote:

Currently, --enable-mbtrn cannot build without --enable-mbtnav. It would be good to have more test configs!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

David W. Caress Principal Engineer Seafloor Mapping Lab

Monterey Bay Aquarium Research Institute 7700 Sandholdt Road Moss Landing, CA 95039

caress@mbari.org http://www.mbari.org/~caress/

Phone: 831-775-1775

dwcaress / MB-System

--enable-mbtrn broken #365