dwcoates / pygn-mode

An Emacs major-mode for chess PGN files, powered by Python
BSD 2-Clause "Simplified" License
10 stars 3 forks source link

Bugfix: always turn on pygn-mode in PGN-containing temp buffers #174

Closed rolandwalker closed 3 years ago

rolandwalker commented 3 years ago

Per #173, if we create a temp buffer containing PGN data, we must turn on pygn-mode if we expect pygn-mode-* defuns to be able to work in that buffer.

Without the tree-sitter parse tree to refer to, many defuns won't work, or will throw exceptions.

We actually should have noticed this issue back in #154, when the mode was set for the temp buffer in the tests.

Secondarily, as comments note throughout, this whole approach of creating and re-parsing is probably slow, and we should work on redesigning some of these to get the same functionality without temp buffers.