dwcoates / pygn-mode

An Emacs major-mode for chess PGN files, powered by Python
BSD 2-Clause "Simplified" License
10 stars 3 forks source link

follow-minor-mode stops working after free motion #182

Open rolandwalker opened 3 years ago

rolandwalker commented 3 years ago

From #174 :

After this PR, pygn-mode-follow-minor-mode works correctly, IFF pygn-mode-next-move and pygn-mode-previous-move are used to navigate. But if I move the cursor freely through variations and comments, the "follow" board window eventually stops being updated at all, and the follow mode stops working.

We need to

dekrueger commented 1 year ago

I added the above commit to get following semi-working. It still doesn't function in variations, probably due to errors in pgn-at-pos-as-if-variation. I tried to be expansive in the commit message. Hopefully it can help you track down this issue.

rolandwalker commented 1 year ago

@dekrueger Hi! Please PR if that's a partial fix. My assumption is that the tree-sitter port broke navigation, and that navigation could now be simplified.