search

dweber019 / backstage-plugins

A collection of Backstage plugins
MIT License
20 stars 7 forks source link

Breaking change when updating ^0.0.5 -> ^0.0.9 #19

Closed JoostvdB94 closed 3 months ago

JoostvdB94 commented 3 months ago

Today, when updating the "@dweber019/backstage-plugin-api-docs-module-wsdl-backend" package from 0.0.5 to 0.0.9, the build was breaking with the following error.

yarn tsc:
   Type '{ logger: Logger; }' is missing the following properties from type 'RouterOptions': discovery, tokenManager

   return await createRouter({ logger: env.logger });
                              ~~~~~~~~~~~~~~~~~~~~~~

I suspect that this was caused by a breaking change in the upgrade. However, the version increase suggests otherwise. Should this have been an major version upgrade?

dweber019 commented 3 months ago

@JoostvdB94 thanks for reporting. Was not intentional and should be mentioned in the change logs for sure.