search

dweber019 / backstage-plugins

A collection of Backstage plugins
MIT License
20 stars 7 forks source link

[end-of-life plugin] Add missing peer dependencies for vis-data and xss #29

Closed manusant closed 2 months ago

manusant commented 2 months ago

The vis-timeline dependency sets some peer dependencies that needs to be set in order to have the dependency graph set properly.

Currently your plugin is not providing them and this makes use of the plugin really hard and confusing.

I kindly ask you to provide the required dependencies as part of your plugin to make sure versions are aligned. Currently failing for vis-data, vis-util and xss libraries but not sure because the vis-timeline sets a bunch of peer dependencies.

To get the typescript issues, please run: 


tsc --skipLibCheck false --incremental false
dweber019 commented 2 months ago

Having a look into this in the next few days. Would be open for PR's too 🙏

dweber019 commented 2 months ago

Fix released