Obtaining the safe_mode config has incorrect closing parenthesis

dweeves / magmi-git

Magmi GitHub

364 stars 306 forks source link

Obtaining the safe_mode config has incorrect closing parenthesis #561

Closed rvelhote closed 3 years ago

rvelhote commented 6 years ago

The condition currently has an incorrect closing parenthesis which causes the parameter to ini_get to be "false". Also with PHP7 ini_get for the "safe_mode" parameter will return a boolean rather than a string. This patch also contains a condition to handle both cases. Both these issues causes remote CSV file downloads that have redirects (i.e. Dropbox) to always fail.

tmotyl commented 3 years ago

safe_mode has been DEPRECATED as of PHP 5.3.0 and REMOVED as of PHP 5.4.0. So it's not present in php7. I can merge this, but support for pre php7 code should be dropped later on