sync-by-unito[bot]
commented
3 years ago ➤ jborek commented:
noerbot spencegarcia
- The issue here is that when we integrated the storeProductCache, we didn't take downstream functionality into account. The reason this is breaking is that the fetchCollection function in the CreateEditMerchstore component.tsx file was altered to gate the collection fetch based off whether the cache was present. However when the product is adjusted from the right sidebar menu further down the chain, it relied on that fetch to repopulate the product data. The issue now is that I initially wrote that sidebar in a way that updating the cache could work (I had originally just passed the data from the product fetch down to the child components I created. However, during Pablo's work on his components, for the sake of not having to access products.edges.node.variants[x].node.blahblahblah further down the code, he converts all the downstream collection data to simplify it (see the setProducts and fetchProductNode functions in the CreateEditMerchstore component). This is one of the things that caused a massive merge conflict during one of the releases as I had to rewire all of my components to work with that new data structure.
tl;dr - When we get down to the component where this is breaking, the data no longer resembles the data in the cache, and the data returned from the API update also doesn't match. So I'm open to suggestions, but I either have to rewire everything downstream to match the cache, or I have to do some comparison work during the product update. Either way, I don't have the time allocated today (or the brainpower, still running a fever over here) to make that fix. I made a quick fix that involves adding a forceFetch parameter to the fetchCollection function which just overrides the cache check on this particular update (in PR #474 ( https://github.com/RangeMPLS/merchology-merch-stores/pull/474 ) My suggestion is we merge that for the sake of the demo, leave this issue open (drop the priority a bit) then with the hours I have later in the week for QA/FR, I can solidify the fix here.
When adjusting the price of a product, receive Toast notification that the product updated, but new price does not save upon refresh. Link to video from Shadab's QA Report for context. https://www.loom.com/share/a219fe5ff47b4e12b7b4732512f4d3ca
┆Issue is synchronized with this Wrike Item by Unito