search

dwerning1 / test-for-wrike

0 stars 0 forks source link

Feature - Frontend Collection Page Sort & Filter #150

Closed sync-by-unito[bot] closed 3 years ago

sync-by-unito[bot] commented 3 years ago

Steps to Test

  1. Open the deploy preview
  2. See the Filter and Sort buttons above the collection table view
  3. Use the buttons to verify that the products filter and sort as expected.
  4. Verify that buttons and behavior look like the designs?node-id=197%3A4220)

Wrike task: https://www.wrike.com/open.htm?id=763717210

┆Issue is synchronized with this Wrike Item by Unito

sync-by-unito[bot] commented 3 years ago

➤ Patrick Nelson commented:

Addressed Natalia's comments from first round of FR.

When you were in the 2nd page of results for example and start filtering, it doesn't reset the pagination, so you have to come back to page 1 say to see results. Same happens with the sorting, it should reset the pagination. Now when filtering and sorting from any page of results other than 1, user goes to the first page of results.

Designs show categories with different numbers and a View all link if there are more than 4 brands for example. The price filter categories don't match the design numbers but maybe this was intended. I added the "View all" link to the product and brand filters (I added a lot more products to qa-static-close store to test this). Levi and I discussed the price filter options and decided on what is in this feature. We also decided that there should not be a "view all" button in the price filter.

I cannot click on $100+ or in brands filters, don't know why. Could not reproduce this locally.

sync-by-unito[bot] commented 3 years ago

➤ natalbarengue commented:

Looks good now, thank you patrickrnelson. Moving to CR