dwerning1 / test-for-wrike

0 stars 0 forks source link

Create edit products product list #33

Closed sync-by-unito[bot] closed 3 years ago

sync-by-unito[bot] commented 3 years ago

This PR finalizes the styles for the product list view. It piggybacks off the functionality of PR #342 . The button functionality does not change but this PR finalizes the styling for the list.

TO TEST:

  1. Open the deploy preview and navigate to /admin/merchstores/M0004.
  2. Click on the products tab. Verify the the styles match the Figma designs?node-id=245%3A7482). (Note that the artwork options section is not a part of this PR).

┆Issue is synchronized with this Wrike Item by Unito

sync-by-unito[bot] commented 3 years ago

➤ Mike Siddall commented:

jborek Styling wise there are a couple things I am unsure of...

  1. Figma shows a scroll bar on the product list itself.
  2. Assuming that the svg in Figma vs code are ok to be different, the sizing of the svg appears to be too small based on Figma.
sync-by-unito[bot] commented 3 years ago

➤ jborek commented:

michaelsiddall

sync-by-unito[bot] commented 3 years ago

➤ Mike Siddall commented:

Styling matches Figma designs.

sync-by-unito[bot] commented 3 years ago

➤ jborek commented:

noerbot

sync-by-unito[bot] commented 3 years ago

➤ Noah Jeffrey commented:

So just conflict resolution and a SUPER minor alignment issue with "Products" on tablets. Then we can get this merged!