search

dwerning1 / test-for-wrike

0 stars 0 forks source link

Edit product updates #53

Closed sync-by-unito[bot] closed 3 years ago

sync-by-unito[bot] commented 3 years ago

This PR adds the functionality for editing a MerchStore's products.

TO TEST:

  1. Open the deploy preview and navigate to /admin/merchstores
  2. Select a merchstore that has products available (I used /merchstores/M0004)
  3. Click view/edit on a product.
  4. A superuser or merchologist can update any of the fields for the store (note that the image section will be completed in another PR and is read only at this point). An admin can only remove a product from the store.
  5. Verify that the designs match the figma files?node-id=251%3A1948)(note that there is a difference between the designs for an admin and a merchologist/superuser).
  6. Verify that modifying the fields and clicking the update button correctly modifies the product in the Shopify admin, as well as reloading the product list view to reflect the changes.

┆Issue is synchronized with this Wrike Item by Unito

sync-by-unito[bot] commented 3 years ago

➤ Patrick Nelson commented:

jborek Looking solid! Just one thing. Editing the description did not update in Shopify. I tried on multiple products and multiple times. The title and price did update, though!

Are the decoration location and deco type dropdowns apart of this task?

sync-by-unito[bot] commented 3 years ago

➤ jborek commented:

patrickrnelson

sync-by-unito[bot] commented 3 years ago

➤ jborek commented:

patrickrnelson

sync-by-unito[bot] commented 3 years ago

➤ Patrick Nelson commented:

jborek Editing the description works but it now deletes the details list, so there won't be anything populated in the "Specs" section on the front-end.

sync-by-unito[bot] commented 3 years ago

➤ Santiago Pence Garcia commented:

Maybe for Merchstores 1.3

sync-by-unito[bot] commented 3 years ago

➤ Santiago Pence Garcia commented:

jborek don't forget to ping me if this is ready for 1.3 today. If it is, please solve the merge conflicts with development!

sync-by-unito[bot] commented 3 years ago

➤ Patrick Nelson commented:

jborek Quill looks great! And updating the description works as intended and everything else in the product page updates. This is ready for CR spencegarcia

sync-by-unito[bot] commented 3 years ago

➤ Santiago Pence Garcia commented:

Merged with https://github.com/RangeMPLS/merchology-merch-stores/pull/375