search

dwerning1 / test-for-wrike

0 stars 0 forks source link

Logo mockup tool reusable image element. #70

Closed sync-by-unito[bot] closed 3 years ago

sync-by-unito[bot] commented 3 years ago

This PR adds a reusable logo mockup tool image element to the project. Notes on the element's usage can be found in the element's README file.

To test:

  1. Open the deploy preview and navigate to a store with that has at least one artwork option (M0004 is an example).
  2. Click to view/edit a product.
  3. Scroll down to the artwork portion of the view. The first artwork option should be selected by default. If the product has a artwork_option= tag assigned to it, that option should be selected instead.
  4. You should see the selected artwork applied to the first product image.
  5. If you click the zoom button on the first image, you should also see the logo applied to the zoomed in image.

NOTES: If you do not see a logo image overlay or you see a broken image, there could be several causes.

  1. In the case of a broken image, check the URL of the selected artwork. The logo tool will only work with artwork saved to the MERCHSTORES or GOT folders in Merchology's Cloudinary account. Some stores (like M0004) were created directly in the database and may have invalid URLs as their artwork. In production, this won't be an issue as all stores will have their logos uploaded via our code.
  2. In the case of no logo being overlaid, check the console. The element will default to displaying the unaltered product image if it can't process the overlay for any reason, i.e. the product has no (or has an invalid) LogoArea= tag applied. It should throw a console error explaining the issue.

┆Issue is synchronized with this Wrike Item by Unito

sync-by-unito[bot] commented 3 years ago

➤ Patrick Nelson commented:

jborek Looking good. Taking your notes into consideration, products loaded the images properly in most cases.

The backpack and the yellow shirt had the logo in one place on the smaller image, but the logo shifted if you expanded the image. Screen Shot 2021-09-09 at 5 03 31 PM ( https://user-images.githubusercontent.com/73553839/132768997-ebd49e4c-11ee-46fe-a27b-5204366800c8.png ) Screen Shot 2021-09-09 at 5 03 44 PM ( https://user-images.githubusercontent.com/73553839/132769018-d17db83b-fe5c-4135-b757-24ef93021944.png )

Also, I was unable to view products in the store that I created (M0105). Was just re-directed to a blank screen. Is that a separate issue?

sync-by-unito[bot] commented 3 years ago

➤ jborek commented:

patrickrnelson

sync-by-unito[bot] commented 3 years ago

➤ Patrick Nelson commented:

jborek Perfect! Changes look good. This is ready for CR dwerning1