Closed sync-by-unito[bot] closed 3 years ago
➤ Patrick Nelson commented:
jborek Very nice! Couple of things
I was unable to test Admin because of the permissions.
➤ jborek commented:
patrickrnelson
To test admin status, you could pull the file down locally and change line 22 of MerchstoreArtworkOptions/component.tsx to const isStoreAdmin = true
➤ Patrick Nelson commented:
jborek Regarding number 1, I was also unable to reproduce lol. Must have been a weird scenario.
Regarding number 5, I was more so talking about the actual image being really blurry and unreadable. Is there a way to make it not smooshed?
One more thing I forgot to mention in the last round, the Artwork Options tooltip says "Contact a Merchologist for additional artwork options" even when I am logged in as a superuser.
Thanks for the Admin info! As an Admin, I was able to edit images for merchstores that already had more than one image uploaded. But I couldn't add more than one image to merchstores that didn't have images. See screenshots. I am an ADMIN in both. Also notice that the edit button goes outside of the box
Screen Shot 2021-09-16 at 11 15 32 AM ( https://user-images.githubusercontent.com/73553839/133648616-712f650c-db11-4895-891e-81d09fd83930.png )
Screen Shot 2021-09-16 at 11 19 03 AM ( https://user-images.githubusercontent.com/73553839/133648629-424c0f4a-c24b-4b33-9077-1ad927fe0528.png )
➤ jborek commented:
patrickrnelson
➤ Patrick Nelson commented:
jborek I found one more thing, sorry I forgot to look at mobile my first time around.
Screen Shot 2021-09-16 at 12 59 15 PM ( https://user-images.githubusercontent.com/73553839/133662086-7f14f83a-cde8-4fe0-9e94-73e9d5855602.png )
Just need some right and left padding / margin to match the designs. After that this is good to go!
This PR adds support for users updating the artwork on their Merchstore.
To test:
┆Issue is synchronized with this Wrike Item by Unito