search

dweymouth / supersonic

A lightweight and full-featured cross-platform desktop client for self-hosted music servers
GNU General Public License v3.0
880 stars 45 forks source link

Improvements to custom themes feature #225

Closed dusnm closed 8 months ago

dusnm commented 1 year ago

This pull request changes the way in which Supersonic handles custom themes in the following ways.

Overview of the change

  1. On Linux, the themes directory was never getting created, the createThemeResources function takes care of that by dumping the default configuration as-is, while making sure that the themes directory exists and has proper permissions.
  2. As the default theme now exists as a file, the "Default" word was removed when drawing the Settings dialog.

Reasons for the change

I wanted to change a couple of colors in the default theme, but I noticed that I didn't have a baseline to start from, the baseline being the default theme. This change makes it obvious where the themes are stored and how they're structured without having to dig through the source code.

Possible causes for concern

This code is tested to work only on Linux operating systems. I'm unsure how it behaves on say, Windows. That's something to look into.

I'm open to any suggestions, thoughts, requests for modification or otherwise. Cheers. 🍻

dweymouth commented 8 months ago

Did you mean to close this? I was waiting for you to make changes from the review but if you want to pick this back up I'd be happy to get it merged

dusnm commented 8 months ago

Yeah. I hope to eventually open a new PR that is based on the latest changes. I just don’t have the time right now. Once I get back from my vacation I’ll try giving it another shot. Take care. 😁