dweymouth / supersonic

A lightweight and full-featured cross-platform desktop client for self-hosted music servers
GNU General Public License v3.0
680 stars 27 forks source link

No MPRIS in Flatpak installations #226

Closed sol8712 closed 11 months ago

sol8712 commented 11 months ago

Supersonic Flatpak 0.5.1 Im not able to use my usual MPRIS enabled media keys, and no media info is shown in GNOME notification area.

On my install i have disabled the Pop! OS specific "cosmic desktop" extension in favor of the vanilla GNOME workflow.

Later i will test a mostly fresh Ubuntu 22.04 install and see if the issue persists there as well, if it does ill create a separate issue for that distro.

sol8712 commented 11 months ago

Could be either a Flatpak related issue, a OS/distro specific issue, or a GNOME 42 issue.

dweymouth commented 11 months ago

My guess is on it being a Flatpak issue. Could you try with the direct download of the executable from the GitHub Releases page? @anarcat Might there be a new permission that needs to be enabled to allow MPRIS D-Bus access?

sol8712 commented 11 months ago

My guess is on it being a Flatpak issue. Could you try with the direct download of the executable from the GitHub Releases page? @anarcat Might there be a new permission that needs to be enabled to allow MPRIS D-Bus access?

Direct download worked as expected! All expected MRPIS functions work great! Now i can control music locally on on my media center PC with my keyboard as well as any android device through KDE connect/GSconnect. This is a wonderful addition! Thank you for all you work @dweymouth and all of team Supersonic!

sol8712 commented 11 months ago

Issue is not yet solved as this is absolutely a Flatpak issue. Appreciate the title change!

anarcat commented 11 months ago

i made a PR attempting to fix this in the flatpak, do you think you could test the build when it's done to confirm it works?

https://github.com/flathub/io.github.dweymouth.supersonic/pull/25

anarcat commented 11 months ago

build passed, i merged and this should end up on flathub soon-ish.

(to be honest i never quite know when builds land on flathub. in this case, i think the 0.5.1 release might get overwritten with the recent changes i made, but i don't quite understand how it works, let alone when those changes do propagate. last time i asked flathub folks about this, they pointed me at https://buildbot.flathub.org and there you can see the current master being built at https://buildbot.flathub.org/#/builders/6/builds/54987... but it doesn't show the build being uploaded when done. so who knows.)

jcharaoui commented 11 months ago

The build page suggests the unpublished builds are of type Test while the latest published ones are Official.

jcharaoui commented 11 months ago

i made a PR attempting to fix this in the flatpak, do you think you could test the build when it's done to confirm it works?

Tested the latest version on my system (Debian 12), and media keys are still not working, and I'm not seeing any media notification from Supersonic.

dweymouth commented 11 months ago

This PR may fix it: https://github.com/flathub/io.github.dweymouth.supersonic/pull/27

@jcharaoui would you be able to test the build? flatpak install --user https://dl.flathub.org/build-repo/38645/io.github.dweymouth.supersonic.flatpakref

anarcat commented 11 months ago

This PR may fix it: flathub/io.github.dweymouth.supersonic#27

who knows! :) let's try! i just merged the PR.

@jcharaoui would you be able to test the build? flatpak install --user https://dl.flathub.org/build-repo/38645/io.github.dweymouth.supersonic.flatpakref

... and soon directly on flathub, YOLO!

jcharaoui commented 11 months ago

It works now, thanks!

anarcat commented 11 months ago

@dweymouth i think this ticket can be closed, thanks @jcharaoui for the tests!