Migrate to Fyne 2.4.0

[adamantike]

@dweymouth, if you haven't started working on this one already, I can give it a try!

[dweymouth]

You're welcome to give it a go - I've been taking a bit of a break from this project recently but am planning to get back into it soon. I briefly tested Supersonic on Fyne 2.4.0 and noticed a few things:

• Most of my Fyne tweaks and API extensions have landed upstream and Supersonic now builds against Fyne 2.4.0 directly (no replace directive needed in the go.mod), but the tweak I made to switch the main loop to 10fps instead of 60fps to save background CPU will not be there. (Maybe the small increase in CPU load is fine) Also I have another Fyne modification to make sure hidden windows can't be re-shown without restarting the run loop on mac) that is not in 2.4.0 (I can add this back in later)
• There is truncation of the last character on some hyperlinks due to a magic number in customhyperlink.go that will need to be adjusted as the font kerning has changed slightly. (customhyperlink is still needed to work around a limitation in the builtin hyperlink)
• List focus handling has been changed and we will need to override the FocusGained method on the builtin list to reject the focus (probably by calling FocusNext) and allow the rows themselves to continue to handle focus and selection (needed because Fyne lists are still single-select)
• GridWrap is now in the base Fyne package (can move away from fyne-x) but the focus handling will need to be overridden as with list, since grid view items shouldn't be focusable (or if they are, we will want the GridViewItems themselves to handle it)
• On Mac I noticed a significant increase in CPU consumption on app launch, that eventually settles down as you start to use the app. Not sure what's going on there or if it happens on other platforms

[adamantike]

Thank you for the context! That's a lot of insight for a "brief" test :)

Most of my Fyne tweaks and API extensions have landed upstream and Supersonic now builds against Fyne 2.4.0 directly (no replace directive needed in the go.mod), but the tweak I made to switch the main loop to 10fps instead of 60fps to save background CPU will not be there. (Maybe the small increase in CPU load is fine) Also I have another Fyne modification to make sure hidden windows can't be re-shown without restarting the run loop on mac) that is not in 2.4.0 (I can add this back in later)

I found that we will still need your fork, specially for the following commits:

• Reduced idle CPU usage (commit https://github.com/dweymouth/fyne/commit/99769cf441c7ba118e199115b0f4a3e36416361d), unless until https://github.com/fyne-io/fyne/pull/4173 gets addressed.
• Restarting run loop on Mac (commit https://github.com/dweymouth/fyne/commit/ca61c153b2a5bb7d226b8f072b1fbd27bc17371a)
• Disabling watch on Preferences (commit https://github.com/dweymouth/fyne/commit/04bb93bb1dd2d075d6d3327dcdef690f5fe4a85d): Not sure about this one.

There is truncation of the last character on some hyperlinks due to a magic number in customhyperlink.go that will need to be adjusted as the font kerning has changed slightly. (customhyperlink is still needed to work around a limitation in the builtin hyperlink)

I found that replacing the current 2.7 factor with 4.0 fixes this (and is the smallest value that stopped generating truncated links).

I can create a PR pointing to the upstream Fyne version, to fix some of those issues, and later on add the replace to point to your updated fork, when you get the chance to rebase!

[dweymouth]

Currently blocked by an CPU use regression related to images - https://github.com/fyne-io/fyne/issues/4345

[dweymouth]

.. and unblocked by https://github.com/dweymouth/supersonic/commit/ffc6a8fc9897cc144dd5f403b7370c760fca1391! @adamantike do you still want to pick this up or should I start working on it?