dweymouth / supersonic

A lightweight and full-featured cross-platform desktop client for self-hosted music servers
GNU General Public License v3.0
675 stars 26 forks source link

please add a "favorite" button #286

Closed anarcat closed 3 weeks ago

anarcat commented 7 months ago

Hello!

Just now, a great song started playing and i immediately thought "oh, i need to favorite that one!" So I went to Supersonic and looked around the UI. Right now , the playback controls look like this:

image

I was expecting a "heart" button there to set the currently playing song as favorite. I figured I can instead go to the "Now Playing" section ("tab"?), find the currently playing track, right-click and "Set favorite" as well, but that seems a bit far out...

Could I have a little "favorite" button pretty please? :)

Thanks again for supersonic, every day use, awesome!

dweymouth commented 7 months ago

You can favorite the current track by right-clicking on the lower left album thumbnail and getting a context menu. I guess it's not very discoverable. I really don't want to clutter the interface too much but maybe overlaying a "..." icon on top of the thumbnail? Or a mini "..." button next to the repeat icon on the bottom right? (Eventually there will be shuffle and cast buttons there too)

I also might add skip forward/backward buttons to the main player controls in the center, and those should definitely stay symmetrical IMO, so not sure that's the place to add something new.

anarcat commented 7 months ago

Oh wow, yeah, there's almost zero chance anyone will find this on their own dude. :p I never even imagined that was there!

So yeah, maybe some UI hint that the cover is right clickable (because I did notice it was left clickable) would possible do things, and yeah, maybe a hamburger menu?

For what it's worth, I really liked how gmpc handled this. This is the playback UI:

image

Not actually a fan of the seek bar, which I basically never used, but everything else was minimal and fine. I never use the "shuffle" feature on music software. Shuffle playlist (which reorders the playlist, instead of picking a random next song), sure, but that's in the playlist UI, not in the playback UI.

(I've always disliked "shuffle" playback because any good RNG will necessarily play the same song twice, sometimes in order, it's just the nature of randomness. While if you reorder a set, each track still will play only once... But that's a whole other thing...)

(Oh, and the other cool thing with gmpc's "favorite" feature is that it didn't actually record an internal setting on the track, out of band: it just appended the track to a favorites.m3u playlist and then you can just run, reorder, whatever that playlist, clever and so simple!)

So anyway for me, a "favorite" button is part of the priority set, but I understand you might feel different. :)

anarcat commented 7 months ago

oh, and yes, i use all those five buttons:

  1. favorite: mentioned before
  2. previous: return to beginning of track, seek to previous track (ideally, "hold" would seek backwards continuously within a track, IMHO)
  3. stop: stop playback, return "cursor" to the beginning of current track (ie. play starts from the top of the current track after)
  4. pause: stop playback, keep "cursor" in place (ie. play starts from current position after)
  5. next: skip to next track
s-fleck commented 2 months ago

I also think an additional button would make sense. Tbh right clicking the album thumbnail and klicking the heart i would expect that it favourites the album, not the track.

dweymouth commented 3 weeks ago

I'm adding a little "option button" to the right of the track title that will bring up an action menu for the current track:

image