search

dweymouth / supersonic

A lightweight and full-featured cross-platform desktop client for self-hosted music servers
GNU General Public License v3.0
675 stars 26 forks source link

Systray icon empty since 0.7.0 #288

Closed sochotnicky closed 7 months ago

sochotnicky commented 7 months ago

I've noticed that systray icon in my (Linux/Sway) system is empty since version 0.7.0. I've ran git bisect and it seems to be caused by commit afcb47f61d93de54fbb181af41bfaf565a716e6c

Specifically following change seems suspicious:

-       fyne.io/systray v1.10.1-0.20230602210930-b6a2d6ca2a7b // indirect
+       fyne.io/systray v1.10.1-0.20230722100817-88df1e0ffa9a // indirect

I idly wonder if this might be related to: https://github.com/fyne-io/systray/pull/49

I haven't done much more debugging yet. If things are unclear I could try to prepare some reproducer.

sochotnicky commented 7 months ago

One note - I can run example from https://github.com/fyne-io/systray/tree/master/example without issues. So I don't think it's necessarily systray issue but maybe something changed in between versions.

dweymouth commented 7 months ago

I think there may have been a Fyne regression that pulled in a version of the systray library with this bug. I could bump the systray dependency version since I'm building on a Fyne fork anyway

sochotnicky commented 7 months ago

I think there may have been a Fyne regression that pulled in a version of the systray library with this bug. I could bump the systray dependency version since I'm building on a Fyne fork anyway

I think you are right. After tweaking go.mod and updating systray with:

-       fyne.io/systray v1.10.1-0.20230722100817-88df1e0ffa9a // indirect
+       fyne.io/systray v1.10.1-0.20231115130155-104f5ef7839e // indirect

Things seem to be working fine again