search

dweymouth / supersonic

A lightweight and full-featured cross-platform desktop client for self-hosted music servers
GNU General Public License v3.0
878 stars 45 forks source link

desktop file shipped with package is incomplete #302

Closed anarcat closed 2 months ago

anarcat commented 9 months ago

This is the desktop file shipped in the 0.8.2 release:

$ tar -x -O -f  Supersonic-0.8.2-linux-x64.tar.xz usr/loc
al/share/applications/Supersonic.desktop;  echo
[Desktop Entry]
Type=Application
Name=Supersonic
Exec=supersonic 
Icon=Supersonic
Keywords=fyne;

while it ... works, it's a far cry from the much more complete, manually built .desktop file available in the source tree:

https://github.com/dweymouth/supersonic/blob/main/res/supersonic-desktop.desktop

the build process should end up generating a file like that instead.

this particularly affects the flatpak package, which (used to) rely on the shipped desktop file (https://github.com/flathub/io.github.dweymouth.supersonic/issues/47). in the beta, it switched to installing the other file manually (https://github.com/flathub/io.github.dweymouth.supersonic/pull/50), but it would be nice to harmonize that across packages and distribution mechanisms.

anarcat commented 2 months ago

hey there, thanks for the fix! i tried to tweak that in the flatpak, in https://github.com/flathub/io.github.dweymouth.supersonic/pull/92/commits/eb188ed274acd13c65a5de8c5e003be654c2c38c, we'll see...