Closed natilou closed 5 months ago
I think the only thing left is to include the new .svg file as well as the changes to bundled_gen.sh
in the PR. But I'm traveling and it may be until mid-week when I have the time to test myself. Thanks for working on this!
I think the only thing left is to include the new .svg file as well as the changes to
bundled_gen.sh
in the PR. But I'm traveling and it may be until mid-week when I have the time to test myself. Thanks for working on this!
Changes made, thanks! Take your time, no rush!
Can you add the bundled_gen.sh
updates as well?
Edit: Nevermind, I was looking at the diff against replace-png-icons which already has the bundled_gen update. Sorry!
Modifications:
browsingpane.go:
AddNavigationButton(
now receives acontroller.PageName
to save in theBrowsingPane
attributenavBtnsPageMap
the pageName and the icon for it.updateNavBtnsColor()
which receives aPage
. The method iterates in each key-value of navBtnsPageMapand if the key is equal to the page received, changes the color of the icon and reset the original color of the other icons. This method is called inside the
doSetPage()`addNavigationButtons()
calls theAddNavigationButton()
with the pageName of each icon and callback.Added new icons for ResHeartFilledSvg and ResHeartOutlineSvg with Font Awesome Free License
Highlight the icon of the current page:![Screenshot from 2023-12-24 17-04-54](https://github.com/dweymouth/supersonic/assets/30585029/326665f7-c512-4339-a400-963b0dce0901)
Highlight the icon of the current page but it doesn't modify the color of the same icon in quick search:![Screenshot from 2023-12-24 17-05-21](https://github.com/dweymouth/supersonic/assets/30585029/cd1dcbd2-7500-428f-a265-2768cb0baca3)
When we are in the page "Artist" the icon of the page "Artists" is not highlighted:![Screenshot from 2023-12-24 17-05-53](https://github.com/dweymouth/supersonic/assets/30585029/6079cb15-7fd3-4a7b-9608-6e4d45d4c05b)
new icon ResHeartFilledSvg:![Screenshot from 2023-12-24 18-05-37](https://github.com/dweymouth/supersonic/assets/30585029/9160c863-5d9a-4cf6-b854-d2b511064168)
new icon ResHeartOutlineSvg:![Screenshot from 2023-12-24 18-06-05](https://github.com/dweymouth/supersonic/assets/30585029/16ebcd28-c649-4b90-927c-03bd514c2ef1)
fixes #218