search

dweymouth / supersonic

A lightweight and full-featured cross-platform desktop client for self-hosted music servers
GNU General Public License v3.0
670 stars 26 forks source link

update fyne to fix opengl bug #313

Closed UltraBlackLinux closed 5 months ago

UltraBlackLinux commented 5 months ago

Hey there, I'm getting the error mentioned in https://github.com/fyne-io/fyne/issues/4419 but it appears they fixed it already. could you update fyne to the latest version? Thanks!

dweymouth commented 5 months ago

Thanks for the heads-up, I will do this for the next release!

dweymouth commented 5 months ago

Not sure what OS you're on, but if your on a Debian-based distro you could try the Github actions build here to see if it fixed it. Or you could build from source from the main branch.

dweymouth commented 5 months ago

I do not have an OS/hardware that this bug reproed on, so it could be helpful if you could verify the fix, else I'll just have to assume it's fixed as the Fyne docs say it should be

UltraBlackLinux commented 5 months ago

Not sure what OS you're on, but if your on a Debian-based distro

firstly, I'm not, I'm on arch. Secondly, I'm on arm64, but I'd be very happy if you could provide a build for that as well, and thirdly, I compiled it from source, because there is no arm64 build.

When I previously tried just manually forcing the fyne version in the go modules (because I suspected that the version you set in there is so old that it doesn't have the fix - it's certainly not the latest release), I got some compilation errors mid way through, so that didn't work.

I'll try building it from source now.

dweymouth commented 5 months ago

When I previously tried just manually forcing the fyne version in the go modules, I got some compilation errors mid way through, so that didn't work.

Yeah, I'm building against a Fyne fork that pulls in a few not-yet-released fixes

UltraBlackLinux commented 5 months ago

Hmm. I'm still getting the same crash. I can see something about the systemtray in the stacktrace, so I'm thinking that it would maybe help to disable that? Could you tell me what I'd need to set in the config to disable it?

Edit: What - the AUR package is building the latest release. Maybe building the main branch would help haha

dweymouth commented 5 months ago

Ah yeah what you mentioned in the edit is probably the issue... but anyway here's my Supersonic config file after stripping out the saved server: https://pastebin.com/HB244yu0 You'd need to edit EnableSystemTray = false to try without the system tray. But I have a feeling it's not the systray that's the issue but just that you were building the latest release :)

Ah, and on Linux the config file is under ~/.config/supersonic/

UltraBlackLinux commented 5 months ago

So, after a lot of back and fourth and struggling with PKGBUILDS I finally got it working! The problem indeed was that I was building the latest release bruh

Thank you so much!

UltraBlackLinux commented 5 months ago

could you rebuild the flatpak package? It does not have the fix and this time I have barely any other good option :/

dweymouth commented 5 months ago

This fix hadn't landed in any release yet. I'll push out 0.9.0, which will have this plus the new features that have landed since the last release.

UltraBlackLinux commented 5 months ago

could you bump the flatpak package as well? I don't know if that auto-builds, but it's definitely not on 9.0.0 yet.

dweymouth commented 5 months ago

We have to wait for the Flatpak maintainer to do that, but they're usually pretty on-top of it

dweymouth commented 5 months ago

Flatpak has been updated