search

dweymouth / supersonic

A lightweight and full-featured cross-platform desktop client for self-hosted music servers
GNU General Public License v3.0
670 stars 26 forks source link

.desktop file executes wrong executable #323

Closed oktayacikalin closed 5 months ago

oktayacikalin commented 5 months ago

I've just updated to the current flatpak release 0.9.0.

Now it does not run using the .desktop file.

The .desktop file tries to execute supersonic-desktop instead of supersonic.

dweymouth commented 5 months ago

@anarcat looks like a bug with the .desktop files creeped in

dweymouth commented 5 months ago

@oktayacikalin in the meantime, you should be able to edit the Flatpak's .desktop file to correct the executable?

anarcat commented 5 months ago

argghll... what the helll.. i thought we had this fixed in the beta?

dweymouth commented 5 months ago

I guess I really need to fix #302 - I'll basically have to extract the Fyne installer package, replace the desktop file, and tar it back up again. Fyne has no interest at the moment in supporting richer .desktop files since they don't want to expose any platform-specific configurations to their build process.

anarcat commented 5 months ago

i guess i lost track of what's going on at all around here anymore, i'm sorry... it doesn't help that i'm using a bespoke desktop env where i start apps basically from the commandline all the time :p

anarcat commented 5 months ago

okay, so it looks like the flatpak is just executing the .desktop file shipped in res/, in your upstream repo (as opposed to the Fyne version)... i don't recall: is there any specific version why the .desktop file calls on supersonic-desktop instead of just supersonic?

i'll figure out a fix in the flatpak for now.

anarcat commented 5 months ago

should hopefully be fixed by https://github.com/flathub/io.github.dweymouth.supersonic/pull/62, a test build will be available there shortly, please test and report back.

dweymouth commented 5 months ago

That .desktop was added at the request of the Arch packager, where it had to be packaged as supersonic-desktop because there was already a package called supersonic.

anarcat commented 5 months ago

On 2024-01-29 18:51:57, Drew Weymouth wrote:

That .desktop was added at the request of the Arch packager, where it had to be packaged as supersonic-desktop because there was already a package called supersonic.

Oh, right. Thanks for the reminder.

anarcat commented 5 months ago

@oktayacikalin this should be fixed in the test build from https://github.com/flathub/io.github.dweymouth.supersonic/pull/62#issuecomment-1916022725, could you give it a shot?

to quote that issue:

Build 96692 successful

To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/79451/io.github.dweymouth.supersonic.flatpakref

let me know, either way i'll probably merge this shortly.

oktayacikalin commented 5 months ago

Build 96692 successful

This build works :+1:

oktayacikalin commented 5 months ago

Is it just me or is the font, using the Larger setting, kind of blurred with this release? (also on fh stable branch)

anarcat commented 5 months ago

This build works 👍

awesome, thanks, i merged it to master and it should show up on mirrors shortly.

Is it just me or is the font, using the Larger setting, kind of blurred with this release? (also on fh stable branch)

things have always seemed blurry for me. i suspect it's because of Xwayland, as we don't do the wayland build just yet. it's probably just more visible if you scale the font up.

otherwise i think this issue should be closed now.