search

dweymouth / supersonic

A lightweight and full-featured cross-platform desktop client for self-hosted music servers
GNU General Public License v3.0
668 stars 26 forks source link

Mac OS Github Actions builds broken #374

Closed dweymouth closed 3 weeks ago

dweymouth commented 2 months ago

It's failing to find <mpv/client.h> for some reason. Change of Homebrew package installed on the actions runners?

dylanagreen commented 1 month ago

I quite like this player so am happy to help out here if I can, but for me it is only the arm build that is broken. I have an M1 mac and am successfully running the mac x64 version through rosetta, but I did notice when I last updated that the arm version crashed with the aforementioned error which is why I switched to x64 (for now). Not sure if that helps or not.

When I had a chance I was going to attempt to build it from source myself again to see if it still breaks, but haven't had the time to do so yet.

dweymouth commented 3 weeks ago

Solved by https://github.com/dweymouth/supersonic/commit/83cf87b1394df34d6269bad4220bd37b8d482805

dweymouth commented 3 weeks ago

...nevermind

dweymouth commented 3 weeks ago

... And actually resolved by 1f761f221351d2c22bee3a56a8b5a5987ee31e95 and the preceding commits