search

dweymouth / supersonic

A lightweight and full-featured cross-platform desktop client for self-hosted music servers
GNU General Public License v3.0
668 stars 26 forks source link

chore: Implement SearchDialog component #380

Closed natilou closed 1 month ago

natilou commented 1 month ago

Currently, this component is used by QuickSearch dialog. And then, it will be used by the "Add to playlist" dialog.

I added some setters and getters to the QuickSearch dialog to abstract the interaction between QuickSearch and SearchDialog from the Controller.

After this PR, I will implement the 'Add to playlist' dialog to incorporate the SearchDialog.

dweymouth commented 1 month ago

Are you planning on using the same visual styling for playlist rows in the Add to Playlist dialog as is currently used for items in Quick Search? If not, you may consider reducing the scope of the SearchDialog and leave the styling of the rows up to the specific use.

natilou commented 1 month ago

You're right. I was working on the "Add to Playlist" dialog using this implementation and I think it would look better if the dialog adjusted its scope based on the rows. I'll change it in this PR.

natilou commented 1 month ago

Sorry, I misunderstood your comment. I'm planning to maintain the same styling for the playlists rows. This is the result: Screenshot from 2024-05-02 20-59-24