dweymouth / supersonic

A lightweight and full-featured cross-platform desktop client for self-hosted music servers
GNU General Public License v3.0
692 stars 29 forks source link

Local cache of artists' images? #417

Closed alessandrococco closed 5 days ago

alessandrococco commented 1 week ago

Hello,

The artists view shows the artists' image:

image

But the artist's page doesn't:

image

Could the artist image be cached locally so it would be shown in the artist page?

dweymouth commented 1 week ago

It uses a different image source for the grid view and the profile pic on the artist page. On the artist page, it uses the largeImageURL from the getArtistInfo2 API - https://opensubsonic.netlify.app/docs/endpoints/getartistinfo2/ - in the gridview it uses the coverArtId property that is returned in getArtists. Both images are cached, and on most servers they are the same. I thought I added a fallback to coverArtId if the largeImageURL isn't present, but maybe I forgot to

dweymouth commented 1 week ago

@alessandrococco you use LMS, right? I think this could be resolved after the fix for https://github.com/epoupon/lms/issues/435 in the latest LMS

alessandrococco commented 5 days ago

@alessandrococco you use LMS, right? I think this could be resolved after the fix for epoupon/lms#435 in the latest LMS

Thanks, I didn't noticed that issue ;-)