search

dwhswenson / contact_map

Contact map analysis for biomolecules; based on MDTraj
GNU Lesser General Public License v2.1
42 stars 18 forks source link

fix matplotlib 3.6 'Unable to determine Axes to steal space for Colorbar #126

Closed sroet closed 2 years ago

sroet commented 2 years ago

With the release of matplotlib 3.6.0 we triggered an error because we relied on deprecated behavior (We did not trigger the deprecation warning as our mappable does not have the attribute axes)

This reinstates the old behavior (grabbing the current axes via plt.gca())

sroet commented 2 years ago

@dwhswenson this one is a one-liner (quick to review) and absolutely required to use any of our plotting with matplotlib 3.6.0, so I hope you will have some time to look at it

sroet commented 2 years ago

I re-enabled unit-tests, let's see if closing and reopening triggers CI

codecov[bot] commented 2 years ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (3793f16) compared to base (b6d2461). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #126 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 13 13 Lines 1153 1154 +1 ========================================= + Hits 1153 1154 +1 ``` | [Impacted Files](https://codecov.io/gh/dwhswenson/contact_map/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+W.H.+Swenson) | Coverage Δ | | |---|---|---| | [contact\_map/plot\_utils.py](https://codecov.io/gh/dwhswenson/contact_map/pull/126/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+W.H.+Swenson#diff-Y29udGFjdF9tYXAvcGxvdF91dGlscy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+W.H.+Swenson). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+W.H.+Swenson)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.