tests: `setup`,`teardown` -> `setup_method`, etc

dwhswenson / contact_map

Contact map analysis for biomolecules; based on MDTraj

GNU Lesser General Public License v2.1

42 stars 18 forks source link

tests: `setup`,`teardown` -> `setup_method`, etc #133

Closed dwhswenson closed 9 months ago

dwhswenson commented 9 months ago

Pytest prefers (and now, apparently requires) the use of setup_method instead of setup.

Looks like there was also a problem to fix about newer pytest not liking pytest.warns(None) as a way to indicate that no warnings were issued.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f276750) 89.27% compared to head (9932e68) 100.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #133 +/- ## ============================================ + Coverage 89.27% 100.00% +10.72% ============================================ Files 13 13 Lines 1091 1154 +63 ============================================ + Hits 974 1154 +180 + Misses 117 0 -117 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dwhswenson commented 9 months ago

This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Mon 29 Jan 17:00 GMT (11:00 my local).

dwhswenson commented 9 months ago

Noting here that the pytest.warns(None) issue had been previously solved by @sroet in #124, which I hadn't merged. I merged that one, hoping that credit will go where it is due. FWIW, the only difference (character-by-character) in our solutions were a single vs double quote (took @sroet's single) and that I had added a comment (kept my additional comment.)