search

dwickern / swagger-play

Swagger API docs for Play Framework
Apache License 2.0
22 stars 4 forks source link

Add version for play 2.8.2 #7

Open detobel36 opened 3 years ago

detobel36 commented 3 years ago

Create a new version:

libraryDependencies += "com.github.dwickern" %% "swagger-play2.8.2" % "3.1.1-SNAPSHOT"

Fix #6

diversit commented 3 years ago

Why is a specific version for Play 2.8.2 needed? One should keep up to date with library dependencies. If you, for some reason, cannot keep up to date, you should not make 'your' problem also someone else's problem by requesting specific version. No-one is stopping you from forking this library yourself and making any changes you require.

Changes to a library should benefit everyone, not just one.

detobel36 commented 3 years ago

Why is a specific version for Play 2.8.2 needed? One should keep up to date with library dependencies. If you, for some reason, cannot keep up to date, you should not make 'your' problem also someone else's problem by requesting specific version. No-one is stopping you from forking this library yourself and making any changes you require.

Changes to a library should benefit everyone, not just one.

I'm agree with you. But in the README page you have a table where it is noted "2.8.0-2.8.7". So I have supposed that this version is compatible with all version from 2.8.0 to 2.8.7. Which is not the case.

I don't have time to do the check for all "sub version". So I made a branch for my project (where I need to use 2.8.2) and I share it here.
If it doesn't help, the owner of the repos could just close my PR...

Please, don't be so negative with a simple proposal 😃