search

dwiel / talon_community

a single source of application-specific scripts
BSD Zero Clause License
121 stars 113 forks source link

soup/trace/quarr/etc repeat one too many times #174

Open jcooper-korg opened 5 years ago

jcooper-korg commented 5 years ago

e.g. "ampersand soup" should produce "&&" but produces "&&&". or "say hello trace" should produce "hellohellohello" but does "hellohellohellohello"

jcooper-korg commented 5 years ago

We're porting these from voicecode, and it is specified in https://voicecode.io/doc/repetition:

"Hello repple two" should be equivalent to "hello soup" both with should produce "hellohello").

This also clarifies that repple 1 and wink will give the same results as repple 2 and soup :

Note, 'hello repple one' will also output hellohello, as in this case it means 'repeat previous once more', whereas every parameter more than 1 means 'repeat previous N times in total'

dwiel commented 5 years ago

The other use case is two separate phrases: "bang" pause "trace". In that case what did voicecode do? And what do we want it to do?

jcooper-korg commented 5 years ago

The result of "bang" pause "trace" (or "bang" pause "repple 3") should be "!!!".

every parameter more than 1 means 'repeat previous N times in total'

This is consistent with how it's worked since the early days of voicecode.