search

dwightjack / grunt-email-boilerplate

A Grunt template to create emails
MIT License
285 stars 52 forks source link

Yeoman generator? #5

Open benoitchantre opened 10 years ago

benoitchantre commented 10 years ago

I think your project is a good candidate to make a Yeoman generator.

dwightjack commented 10 years ago

Thank you for the hint, i'll look into it :)

jahvi commented 10 years ago

I'm currently working on doing a yeoman port of this project, I initially wanted to do it for personal projects but I can push it to github when it's finished if you want to take a look

jahvi commented 10 years ago

Here you go

Keep in mind this is something I just put together today so it's possible that it has some bugs but feel free to give it a try.

dwightjack commented 10 years ago

@jahvi I gave a look at the generator and looks great. I've found a couple of typos on the _Gruntfile.js file (made a PR with fixes.

Also I noticed some improvements from my project which i'd like to apply here too. I'd be great to collaborate to merge or keep aligned the two projects but i'm not sure how we may do that. Any hint?

jahvi commented 10 years ago

Thanks I just merged your PR, I'm still missing some features from your version like EJS support but feel free to contribute if you can.

Initially I wanted to fork your version and work on top of that, this should have made things easier to keep both projects up to date but like I told you this was supposed to be a personal project so I didn't give it much thought. I can keep an eye on your version and manually cherry pick the changes for now.

There are some thing I did differently though, like removed unused variables and options in the gruntfile, removed grunt-open and use the open option in the connect task, include livereload, renamed the test task to send (this was mostly because usually the test keyword is reference to run unit tests and such so I thought it could cause confusion), added the compass config options in the gruntfile directly instead of a separate file and removed dev option from premailer and send tasks, I didn't find useful sending the dev version of the email for testing since the dist version will be the one that ends up being used but if you have a reason for it or any of the other changes please let me know.

I also didn't include devcode because I wanted to keep it simple, it just looked like an overkill for developing HTML emails but if you think it'd be nice to have let me know, I couldn't think of a good use case personally.

I'm open to any suggestions, this is actually my 2nd yeoman generator so it's always nice to learn.