search

dwightjack / grunt-email-boilerplate

A Grunt template to create emails
MIT License
285 stars 52 forks source link

Make premailer a stand alone grunt plugin #7

Closed jahvi closed 10 years ago

jahvi commented 11 years ago

Have you thought about porting the premailer task as a stand alone grunt plugin? It'd be pretty nice.

dwightjack commented 11 years ago

Hi, I'm porting every custom task to external grunt plugins. Right now im working on the nodemailer task, but yes: my plans are to even move premailer to a standalone plugin.

dwightjack commented 11 years ago

Hi @jahvi, I managed to make the task as a standalone plugin:

https://github.com/dwightjack/grunt-premailer

Some functionalities have changed, expecially the HTML vs TXT rendering which now requires 2 separate sub tasks with mode: html | txt.

Next step will be to adapt the boilerplate and get started with the integration/contribution to your yeoman generator.

jahvi commented 11 years ago

That's great I'll try to get implemented, it's been kind of hard trying to find time to get at least v1.0 ready but I'll work on it

dwightjack commented 11 years ago

Hi @jahvi, managed to move both nodemailer and premailer to external tasks in v0.2.3. Also renamed test task to send as you did (since now main mailing task is nodemailer)

dwightjack commented 10 years ago

Fixed some problems, now the grunt-premailer plugin works fine