Bundler Support - Githubissues

dwightjack / grunt-premailer

Grunt wrapper task for Premailer

MIT License

114 stars 16 forks source link

Bundler Support #19

Closed iszak closed 10 years ago

iszak commented 10 years ago

I would like to use grunt-premailer with bundler as I have many different projects that require different ruby dependencies. To my knowledge, there is no way to do this, so my pull request is to add this functionality much like grunt-contrib-compass. I have also added documentation for the newly added default. In an attempt to prevent breakages I have set it to false by default.

dwightjack commented 10 years ago

This is a good point.

A couple of things before merging:

I don't get what's the keys.splice(keys.indexOf('bundleExec', 1)); is about since i don't see where keys is used
In the docs there's a typo referring to compass compile.

Thanks for contributing!

iszak commented 10 years ago

Hey,

I've updated the documentation and defined the keys variable. Sorry for the bad pull request, I actually applied this to the NPM version which is slightly different than what was on master and had to port it.

Thanks for the prompt reply!

dwightjack commented 10 years ago

Nevermind :)

PR merged and pushed to v0.2.9

Thanks again!