search

dwightjack / grunt-premailer

Grunt wrapper task for Premailer
MIT License
114 stars 16 forks source link

Added ability to remove scripts via Premailer #9

Closed Sawtaytoes closed 10 years ago

Sawtaytoes commented 10 years ago

Noticed you're using Git Flow. I added code in here for the GitHub issue I made: https://github.com/dwightjack/grunt-premailer/issues/8.

I have not tested the code, but it looks like I hit all the right spots.

dwightjack commented 10 years ago

Thanks for the PR.

Pushed and published a new version (0.2.6) to NPM.

Sawtaytoes commented 10 years ago

Seems when I output verbosely, the removeScripts option isn't actually deviating from the default. It's always true for whatever reason.

dwightjack commented 10 years ago

Hi. Are your latest PR related to this issue or is it still in need of investigation?

Sawtaytoes commented 10 years ago

It might be. It's only that one. I think there's a setting in another place I missed.

On Tue, Apr 22, 2014 at 1:23 AM, Marco Solazzi notifications@github.comwrote:

Hi. Are your latest PR related to this issue or is it still in need of investigation?

— Reply to this email directly or view it on GitHubhttps://github.com/dwightjack/grunt-premailer/pull/9#issuecomment-41007487 .

dwightjack commented 10 years ago

Ok, will check later today. :)

dwightjack commented 10 years ago

Hi,

merged your PR, thanks.

I've tested with the verbose option and everything seems to work fine. Let me know if you still experience problems.