search

dwightwatson / validating

Automatically validating Eloquent models for Laravel
MIT License
968 stars 76 forks source link

Support for Lumen without Facades? #132

Open jonaholsson opened 9 years ago

jonaholsson commented 9 years ago

Any plans to support Lumen with $app->withFacades(); disabled in /bootstrap/app.php and referencing the libraries manually (e.g. Input and Validator)?

dwightwatson commented 9 years ago

Yeah, wondering what the best approach to access those services would be then. The facades are currently used in the tests. I suppose one approach would be to use app('Illuminate\Validation\Factory') and app('Illuminate\Http\Request') but not sure how I would update the tests for that.

Happy for any other suggestions or PRs, I'd like to see Lumen support sans-Facades if possible.

jonaholsson commented 9 years ago

I'll take a look and see what can be done, but won't have time until end of next week I'm afraid.