search

dwightwatson / validating

Automatically validating Eloquent models for Laravel
MIT License
968 stars 76 forks source link

Laravel 5.8 Compatibility #211

Closed gazugafan closed 5 years ago

gazugafan commented 5 years ago

Using Event::dispatch instead of Event::fire (deprecated in Laravel 5.4 and removed in Laravel 5.8)

dwightwatson commented 5 years ago

Thanks for this - are you able to update the tests as well?

gazugafan commented 5 years ago

Sure! It was just a 5 second 1 word change. I didn't realize you had tests running. I don't have an environment setup to run them, so you'll probably be able to update them way quicker. Let me know if you can't, though.

dwightwatson commented 5 years ago

Cool - will do. Looks like I'll need to update the constraints to stop supporting Laravel 5.3.x for this change too. Thanks again.