search

dwilkie / carrierwave_direct

Process your uploads in the background by uploading directly to S3
MIT License
840 stars 182 forks source link

Carrierwave's cache_id being mistaken for guid when not uploaded directly. #101

Open nddeluca opened 10 years ago

nddeluca commented 10 years ago

When using an uploader that uses carrierwave_direct, uploads that are not done directly mistakenly use carrierwaves temporary cache_id as part of the filename. This gives inconsistent url's between files that are directly uploaded and those that are not.

Files should be able to be directly uploaded by the user or programmatically uploaded by the server without any change in url behavior.

kevinc commented 7 years ago

@nddeluca sorry to resurrect an old issue, but is there anything I can do on my side to get around this? I'm running into this also

p8 commented 7 years ago

@kevinc This should be fixed with the following https://github.com/dwilkie/carrierwave_direct/pull/198

kevinc commented 7 years ago

thanks @p8! just found that and adding it to my codebase until v0.0.16 is out.

p8 commented 7 years ago

Great! Let us know if it solves this issue.

kevinc commented 7 years ago

adding this in addition to https://github.com/nddeluca/carrierwave_direct/pull/1 seems to have fixed my issue

kevinc commented 7 years ago

looks like i spoke too soon @p8 . i'm still having the issues where it's doubling up a section of the URL.

I've gone down the road of pointing my Gemfile at the latest commit and the problem still persists, similar to: https://github.com/dwilkie/carrierwave_direct/pull/160 https://github.com/dwilkie/carrierwave_direct/issues/118