search

dwilkie / carrierwave_direct

Process your uploads in the background by uploading directly to S3
MIT License
839 stars 181 forks source link

Got rid of uuidtools dependency #185

Closed fabn closed 8 years ago

fabn commented 9 years ago

Since you're targeting ruby >= 1.9 there's no need to include an additional dependency.

Use SecureRandom.uuid instead.

dwilkie commented 9 years ago

@fabn I'm not maintaining this project anymore. Are you interested in becoming a maintainer? You can make updates and merge PR as you wish.

p8 commented 9 years ago

@fabn Could you remove the 1.9.3 from the travis.yml?

fabn commented 9 years ago

@fabn I'm not maintaining this project anymore. Are you interested in becoming a maintainer? You can make updates and merge PR as you wish.

Why not. I'll be glad to help

@fabn Could you remove the 1.9.3 from the travis.yml?

Done. At this point I think support for 1.9 should be dropped since it has reached end of life.

If you're fine with that I can also update gemspec to enforce that.

dwilkie commented 9 years ago

@fabn you should have write access to this repo now

fabn commented 9 years ago

Yes, got it. I'd like to hear from other collaborators if my proposal is fine before merge.

/cc @nddeluca @p8? What do you think?

Is it fine to drop 1.9 support entirely?

dwilkie commented 9 years ago

from my perspective it's fine, but check with @nddeluca and or @p8 first as they are maintaining the gem

fabn commented 9 years ago

Added a commit for it. I'll wait their opinions before merging this.

Meanwhile I'll try to walk the issue list to see if there is something I can do to cut the list of open issues.

p8 commented 9 years ago

I'm fine with the drop.