At the moment, both the "main" function and each of the utilility functions have their own ReadDataVector collecting visitiors. Which leads to a whole heap of replicated code.
It would make more sense to have a single 'ReadData collector' function, with different visitors to deal with the resulting vectors. This design would also make it easier to swap out Bamtools for and htslib pileup in the future.
At the moment, both the "main" function and each of the utilility functions have their own
ReadDataVectorcollecting visitiors. Which leads to a whole heap of replicated code.It would make more sense to have a single 'ReadData collector' function, with different visitors to deal with the resulting vectors. This design would also make it easier to swap out
Bamtoolsfor andhtslibpileup in the future.