search

dwinter / mmod

Differentiation statistics in R
Other
11 stars 5 forks source link

use nPop instead of length(seppop()) #4

Closed zkamvar closed 9 years ago

zkamvar commented 9 years ago

Hi. I noticed that in pairwise_fxn, you separate the populations and take the length of the list to figure out how many you need (these two lines). This is perhaps better done with the nPop() accessor:

n.pops <- nPop(x)

Cheers, Zhian

dwinter commented 9 years ago

Thanks again @zkamvar, I'm sure I had some reason to go through those extra steps at some stage.... (?). But you're right, the nPop accessor would be much cleaner.

I'll make the change and wait to see if the release I just send to CRAN survives the gauntlet to see if it makes into this release or the next one.