search

dwmkerr / angular-modal-service

Modal service for AngularJS - supports creating popups and modals via a service.
MIT License
626 stars 321 forks source link

Remove coverage stuff from build output #203

Closed StormPooper closed 7 years ago

StormPooper commented 7 years ago

So after my last pull request was accepted (thanks again for that) and we went to update to the latest version, we started getting errors in our build environment.

Digging into it, it turns out that the coverage test stuff was being included within the actual distribution files, which our build server started to panic over. To prevent this, I've moved the isparta-loader to only be included when running karma tests, as this prevents the dst files being created with coverage within them but still generates the coverage report.

@dwmkerr - I've tested this out with each npm script included and it appears to work for me, but I'm no webpack expert, so if you'd prefer to make changes or just close the pull request and update it yourself it's not a problem. GitHub collapses the dst files by default, but if you expand them you'll see that there is no more coverage stuff in there.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.8%) to 88.542% when pulling 19d809053cfedd14d9e7f8a109a42540481b10bc on StormPooper:master into 8fa713dc9cd04aba6c468681c993669cd0b16207 on dwmkerr:master.

dwmkerr commented 7 years ago

Hi Daniel, OK cool thanks for such a speedy update! Let me clone the PR, run the tests locally and then I'll rush out a release to patch this issue

StormPooper commented 7 years ago

Thanks Dave, if you need to make any changes you should be able to push to my branch and include it in the pull request, go right ahead.

StormPooper commented 7 years ago

Hi @dwmkerr, did you get a chance to look this over?

StormPooper commented 7 years ago

Hey @dwmkerr, sorry to bother you, but did you get a chance to try out the changes?

dwmkerr commented 7 years ago

Hi @StormPooper sorry for the delay, been a little ill the last few days! I've just merged, tested, pushed and released, this is now in the latest version, 0.11.1. Thanks again!

StormPooper commented 7 years ago

No problem, I get how it is, thanks very much!