dwmkerr / angular-modal-service

Modal service for AngularJS - supports creating popups and modals via a service.
MIT License
626 stars 321 forks source link

Latest Release Breaks CSP Rules #204

Closed tylerFowler closed 7 years ago

tylerFowler commented 7 years ago

The latest release distribution has this line:

var __cov_LJ6y9QsEYJy7cg83eFQGGg = Function('return this')();

Along with a bunch of paths to someone's local Windows machine, I assume that it was simply introduced by mistake but when you combine this line with sensible CSP rules browsers will complain that script-src: 'unsafe-eval' needs to be enabled.

dwmkerr commented 7 years ago

Not sure this is still an issue (at least with v0.12). Closing now but please re-open if you still face challenges.