search

dwmkerr / angular-modal-service

Modal service for AngularJS - supports creating popups and modals via a service.
MIT License
626 stars 321 forks source link

added support for passing a selector to appendElement #252

Closed decherneyge closed 5 years ago

decherneyge commented 5 years ago

I added the ability to pass a string of a selector to appendElement instead of having to have the angular.element.

codecov[bot] commented 5 years ago

Codecov Report

Merging #252 into master will increase coverage by 0.5%. The diff coverage is 83.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #252     +/-   ##
=========================================
+ Coverage   83.33%   83.83%   +0.5%     
=========================================
  Files           1        1             
  Lines          96       99      +3     
=========================================
+ Hits           80       83      +3     
  Misses         16       16
Impacted Files Coverage Δ
src/angular-modal-service.js 83.83% <83.5%> (+0.5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a03d00...4311e21. Read the comment docs.

dwmkerr commented 5 years ago

Love it, thanks @decherneyge!