Prevent close callbacks from running multiple times

[DougKeller]

Addresses issue #258

Solution

1. Move the hasAlreadyBeenClosed guard clase to the beginning of the modal's close function
2. on $locationChangeSuccess, call the same close function so that closing the modal is always done the same way

Implications of this solution

• Because $on('$locationChangeSuccess') now calls inputs.close rather than cleanUpClose, preClose will be called on $locationChangeSuccess as well. This seems like an enhancement to me, but it is different from how it behaved before.

[codecov[bot]]

Codecov Report

Merging #259 into master will increase coverage by 0.91%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   85.32%   86.23%   +0.91%     
==========================================
  Files           1        1              
  Lines         109      109              
==========================================
+ Hits           93       94       +1     
+ Misses         16       15       -1

Impacted Files	Coverage Δ
src/angular-modal-service.js	86.23% <100%> (+0.91%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06a7b74...29ef82a. Read the comment docs.

[dwmkerr]

Excellent, thank you @DougKeller!