search

dwmkerr / angular-modal-service

Modal service for AngularJS - supports creating popups and modals via a service.
MIT License
626 stars 321 forks source link

Wait for scope bindings to be set before initializing component modals. #280

Open DougKeller opened 4 years ago

DougKeller commented 4 years ago

This ensures that component bindings are available in the $onInit callback of the component's lifecycle This addresses the main issue with $onInit brought up by #270

codecov[bot] commented 4 years ago

Codecov Report

Merging #280 (8bc68d2) into master (3ddaf86) will increase coverage by 0.17%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   88.54%   88.72%   +0.17%     
==========================================
  Files           1        1              
  Lines         131      133       +2     
==========================================
+ Hits          116      118       +2     
  Misses         15       15
Impacted Files Coverage Δ
src/angular-modal-service.js 88.72% <100.00%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ddaf86...8bc68d2. Read the comment docs.