search

dwmkerr / crosswords-js

Tiny, lightweight crossword control for the web.
https://dwmkerr.github.io/crosswords-js/
MIT License
71 stars 27 forks source link

Update dependencies and tweak crossword css #12

Closed pvspain closed 1 year ago

pvspain commented 1 year ago

Update dependencies - using node 18.14 crossword-css-mods:

guardrails[bot] commented 1 year ago

:warning: We detected 5 security issues in this pull request:

Vulnerable Libraries (5)
Severity | Details ----- | -------- N/A | [pkg:npm/debug@2.6.9@2.6.9](https://github.com/dwmkerr/crosswords-js/blob/764f72b894fbcc464b9f11556c735f8b51e3e677/package-lock.json) (t) upgrade to: *3.1.0* Critical | [pkg:npm/uglify-js@3.17.4@3.17.4](https://github.com/dwmkerr/crosswords-js/blob/764f72b894fbcc464b9f11556c735f8b51e3e677/package-lock.json) (t) - **no patch available** High | [pkg:npm/flat@5.0.2@5.0.2](https://github.com/dwmkerr/crosswords-js/blob/764f72b894fbcc464b9f11556c735f8b51e3e677/package-lock.json) (t) - **no patch available** High | [pkg:npm/json5@1.0.2@1.0.2](https://github.com/dwmkerr/crosswords-js/blob/764f72b894fbcc464b9f11556c735f8b51e3e677/package-lock.json) (t) upgrade to: *2.2.2* High | [pkg:npm/express@4.18.2@4.18.2](https://github.com/dwmkerr/crosswords-js/blob/764f72b894fbcc464b9f11556c735f8b51e3e677/package-lock.json) (t) - **no patch available** More info on how to fix Vulnerable Libraries in [JavaScript](https://docs.guardrails.io/docs/en/vulnerabilities/javascript/using_vulnerable_libraries.html?utm_source=ghpr#).

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

dwmkerr commented 1 year ago

This is great thank-you @pvspain !

dwmkerr commented 1 year ago

If you are planning to make more changes let me know, I'll add 'all contributors' to the project and a few other things hopefully to make it friendlier for contributors!

pvspain commented 1 year ago

Hi Dave,

Thanks! Yes, I'd like to be a contributor please. As part of familiarising myself with the code. I thought I would address some of the ES lint issues - which will involve some simple refactoring. Node LTS now supports most of the latest ES features according to node green https://node.green/

Feature-wise, I noticed there is code to advance to the next cell as you type, but that doesn't work(?). It's a feature I miss. Was that just a stub, or did you have second thoughts?

Cheers, Paul

On Fri, 10 Feb 2023 at 12:14, Dave Kerr @.***> wrote:

If you are planning to make more changes let me know, I'll add 'all contributors' to the project and a few other things hopefully to make it friendlier for contributors!

— Reply to this email directly, view it on GitHub https://github.com/dwmkerr/crosswords-js/pull/12#issuecomment-1425043489, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFO4SZJ6Z5TNHEGZ2YNPQLWWWI7BANCNFSM6AAAAAAUWFQV3E . You are receiving this because you were mentioned.Message ID: @.***>

pvspain commented 1 year ago

Hi Dave, Thanks for the add as a repo participant. Do you want to have a look over these changes first? Mostly addressing lint errors with some refactoring to accommodate ES changes.

dwmkerr commented 1 year ago

Thanks @pvspain I've merged this now, also just merged another branch that has some more developer friendly fixes:

However, the highest priority issues are:

I'd love any help on fixing up the first two issues for now, then maybe we can take a look at the 'TODO' section of the README, which has a quick and dirty list of open issues?

"All contributors" is really nice, I add a comment like the one below this and it creates a PR adding the contributor. Release please checks for changes to main, then looks at the commit history and then proposes updates to the changelog, version number and builds a release PR.

The changes I've made so far are in #14

dwmkerr commented 1 year ago

@all-contributors please add @dwmkerr for build, doc, code, test.

@all-contributors please add @pvspain for build, docs, code, tests

allcontributors[bot] commented 1 year ago

@dwmkerr

I've put up a pull request to add @contributor! :tada:

I've put up a pull request to add @pvspain! :tada:

allcontributors[bot] commented 1 year ago

@dwmkerr

I've put up a pull request to add @dwmkerr! :tada:

@pvspain already contributed before to doc, code, test