Closed mmkal closed 8 months ago
Really nice and really nice documentation as well.
@all-contributors please add @mmkal for docs, code, review
@dwmkerr
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 660
@pvspain any objections to me merging this in?
@mmkal would you mind updating from main
? I've fixed a mistake in the 'all contributors' config which means I should then be able to use the bot to add you to the contributor list on the main page - sorry for the hassle!
@mmkal would you mind updating from
main
? I've fixed a mistake in the 'all contributors' config which means I should then be able to use the bot to add you to the contributor list on the main page - sorry for the hassle!
Yes, will do later tonight (EST time(!)). I want to merge from main anyway, now that #45 is in, so the diff is easier to grok.
@dwmkerr done!
Thanks @mmkal. I'm happy with this @dwmkerr if you want to pull the trigger?
Yep looks great thanks @mmkal and @pvspain !
@all-contributors please add @mmkal for code, docs, review
@dwmkerr
I've put up a pull request to add @mmkal! :tada:
Second attempt at #41
This doesn't go as far as dropping LESS completely (per @pvspain's comment), but it does reduce the dependency by switching over more LESS variables to CSS variables.
The rationale (summing up from the other PR): it makes customising styling easier for developers using this library - CSS variables can be set in userland CSS files which override defaults in crosswords-js, and they will be applied consistently everywhere (for example, changing the cell "highlight" colour and making sure it's in sync across clues, the grid and any other elements users might add; or adding a new screen-width breakpoint with a bigger or smaller cell size).
I've added some docs under
### Styling
in the root readme. They could be more exhaustive but they will point developers using this library in the right direction, and I want to avoid docs churn.Rationale for not ditching LESS right now:
I also ran the
build
script since thedist/
folder was out of date again. I might open a separate PR that does only that to merge in first, though, since then it'd be easier to see what the net effect of this PR is (including the fact that it net removes code despite adding functionality).