search

dwmkerr / glmnet

GlmNet is a .NET version of the excellent OpenGL Mathematics library (GLM).
MIT License
53 stars 20 forks source link

Multiplications between vectors and matrices not supported? #2

Closed chrispepper1989 closed 9 years ago

chrispepper1989 commented 9 years ago

I can't seem to find the functionality that allows me to multiply a vector by a matrix

e.g.

vec2 transformedVector = pos * modelMatrix;

dwmkerr commented 9 years ago

Looks like it is missing, apologies I am porting over the features as I need them so I'll add this ASAP

chrispepper1989 commented 9 years ago

cheers :)

chrispepper1989 commented 9 years ago

If you need another contributor I might be able to help out

dwmkerr commented 9 years ago

I'd welcome any help! I've added a CI build in Travis, if you have the time any help would be much appreciated, I've implemented very little of the glm functionality so far. Multiplication operations would be great, I'll have a crack at this now, write some tests and send them up

dwmkerr commented 9 years ago

@chrispepper1989 v0.3.0 is released, I've added support for multiplication (just make sure to get the order right):

vec2 transformedVector = pos * modelMatrix; // won't work
vec2 transformedVector = modelMatrix * pos; // will work

So I'll close this issue now

chrispepper1989 commented 9 years ago

Cheers dwmkerr :) for contributions should I clone and push? I haven't contributed to github before so I am unfamiliar with the model

dwmkerr commented 9 years ago

For contributions on GitHub, first you fork the repository, meaning you have a copy of your own you can work on. Then you create the changes you want to see in the project, commit them and push them. Once you've done that, you can create a Pull Request, which allows me to see all of the changes you've made and them merge them into the master repository.

There's a nice overview of this at: https://help.github.com/articles/fork-a-repo/

chrispepper1989 commented 9 years ago

Brilliant thank you :)

final question...whats travis?

On 3 December 2014 at 06:29, Dave Kerr notifications@github.com wrote:

For contributions on GitHub, first you fork the repository, meaning you have a copy of your own you can work on. Then you create the changes you want to see in the project, commit them and push them. Once you've done that, you can create a Pull Request, which allows me to see all of the changes you've made and them merge them into the master repository.

There's a nice overview of this at: https://help.github.com/articles/fork-a-repo/

— Reply to this email directly or view it on GitHub https://github.com/dwmkerr/glmnet/issues/2#issuecomment-65361685.

dwmkerr commented 9 years ago

Hi @chrispepper1989 Travis is a CI (Continuous Integration) platform. It basically lets you run a series of tasks every time there is a checkin or against every pull request. It then lets you see whether a pull request will break the build, cause tests to fail and so on, you can see it here:

https://travis-ci.org/dwmkerr/glmnet

It's what provides the 'Build Passing' status icon on the homepage.